CHECK: Macro argument 'module_id' may be better as '(module_id)' to avoid precedence issues
#103: FILE: src/include/sof/library_manager.h:69:
+#define GET_LIB_ID(module_id) (module_id >> LIB_ID_SHIFT)

CHECK: Macro argument 'module_id' may be better as '(module_id)' to avoid precedence issues
#104: FILE: src/include/sof/library_manager.h:70:
+#define GET_MODULE_INDEX(module_id) (module_id & 0xFFF)

CHECK: Alignment should match open parenthesis
#153: FILE: src/include/sof/library_manager.h:119:
+int lib_manager_allocate_module_instance(uint32_t module_id,
+									uint32_t instance_id,

CHECK: Alignment should match open parenthesis
#168: FILE: src/include/sof/library_manager.h:134:
+uint32_t lib_manager_allocate_module(const struct comp_driver *drv,
+							struct comp_ipc_config *ipc_config,

WARNING: please write a paragraph that describes the config symbol fully
#217: FILE: src/library_manager/Kconfig:7:
+config LOADABLE_MODULES

CHECK: Please don't use multiple blank lines
#242: FILE: src/library_manager/library_manager.c:12:
+
+

CHECK: Please don't use multiple blank lines
#263: FILE: src/library_manager/library_manager.c:33:
+
+

CHECK: Please don't use multiple blank lines
#271: FILE: src/library_manager/library_manager.c:41:
+
+

CHECK: Avoid CamelCase: <SystemAgentStart>
#272: FILE: src/library_manager/library_manager.c:42:
+extern void *SystemAgentStart(uint32_t entry_point, uint32_t module_id,

WARNING: externs should be avoided in .c files
#272: FILE: src/library_manager/library_manager.c:42:
+extern void *SystemAgentStart(uint32_t entry_point, uint32_t module_id,

CHECK: Alignment should match open parenthesis
#273: FILE: src/library_manager/library_manager.c:43:
+extern void *SystemAgentStart(uint32_t entry_point, uint32_t module_id,
+		uint32_t instance_id, uint32_t core_id, void *mod_cfg);

CHECK: Please don't use multiple blank lines
#275: FILE: src/library_manager/library_manager.c:45:
+
+

CHECK: spaces preferred around that '*' (ctx:VxV)
#277: FILE: src/library_manager/library_manager.c:47:
+#define CAVS18_MAX_MANIFEST_SIZE  (38*1024)
                                      ^

CHECK: Please don't use multiple blank lines
#281: FILE: src/library_manager/library_manager.c:51:
+
+

CHECK: Alignment should match open parenthesis
#312: FILE: src/library_manager/library_manager.c:82:
+static uint8_t *lib_manager_get_instance_bss_address(uint32_t module_id, uint32_t instance_id,
+						struct sof_man_module *mod)

CHECK: Alignment should match open parenthesis
#320: FILE: src/library_manager/library_manager.c:90:
+	tr_dbg(&lib_manager_tr,
+			"lib_manager_get_instance_bss_address() instance_bss_size: 0x%x, pointer: 0x%x",

CHECK: Alignment should match open parenthesis
#326: FILE: src/library_manager/library_manager.c:96:
+int lib_manager_allocate_module_instance(uint32_t module_id, uint32_t instance_id,
+						uint32_t is_pages, struct sof_man_module *mod)

CHECK: Alignment should match open parenthesis
#335: FILE: src/library_manager/library_manager.c:105:
+		tr_err(&lib_manager_tr,  "is_pages (%d) invalid, required: %d",
+				is_pages, bss_size/HOST_PAGE_SIZE);

CHECK: spaces preferred around that '/' (ctx:VxV)
#335: FILE: src/library_manager/library_manager.c:105:
+				is_pages, bss_size/HOST_PAGE_SIZE);
 				                  ^

CHECK: Alignment should match open parenthesis
#347: FILE: src/library_manager/library_manager.c:117:
+uint32_t lib_manager_allocate_module(const struct comp_driver *drv,
+		   struct comp_ipc_config *ipc_config,

CHECK: Alignment should match open parenthesis
#366: FILE: src/library_manager/library_manager.c:136:
+	ret = lib_manager_allocate_module_instance(module_id, IPC4_INST_ID(ipc_config->id),
+			base_cfg->is_pages, mod);

CHECK: Unnecessary parentheses around mod->uuid[0]
#430: FILE: src/library_manager/library_manager.c:200:
+	drv->uid = (struct sof_uuid *)&(mod->uuid[0]);

CHECK: Alignment should match open parenthesis
#446: FILE: src/library_manager/library_manager.c:216:
+static int lib_manager_dma_buffer_init(struct lib_manager_dma_buf *buffer, uint32_t size,
+				 uint32_t align)

CHECK: Alignment should match open parenthesis
#467: FILE: src/library_manager/library_manager.c:237:
+	tr_dbg(&lib_manager_tr, "lib_manager_dma_buffer_init(): 0x%x, 0x%x",
+			buffer->addr, buffer->end_addr);

CHECK: Please don't use multiple blank lines
#471: FILE: src/library_manager/library_manager.c:241:
+
+

CHECK: Alignment should match open parenthesis
#490: FILE: src/library_manager/library_manager.c:260:
+	dma_ext->dma.dmac = dma_get(DMA_DIR_HMEM_TO_LMEM, 0, DMA_DEV_HOST,
+			DMA_ACCESS_EXCLUSIVE);

CHECK: Alignment should match open parenthesis
#498: FILE: src/library_manager/library_manager.c:268:
+	ret = dma_get_attribute(dma_ext->dma.dmac, DMA_ATTR_BUFFER_ADDRESS_ALIGNMENT,
+					&addr_align);

CHECK: Please don't use multiple blank lines
#522: FILE: src/library_manager/library_manager.c:292:
+
+

CHECK: Please don't use multiple blank lines
#583: FILE: src/library_manager/library_manager.c:353:
+
+

CHECK: Alignment should match open parenthesis
#607: FILE: src/library_manager/library_manager.c:377:
+static int lib_manager_store_library(struct lib_manager_dma_ext *dma_ext, uint32_t lib_id,
+				uint32_t addr_align)

CHECK: No space is necessary after a cast
#612: FILE: src/library_manager/library_manager.c:382:
+			(struct sof_man_fw_desc *) (buff_ptr + SOF_MAN_ELF_TEXT_OFFSET);

CHECK: Alignment should match open parenthesis
#630: FILE: src/library_manager/library_manager.c:400:
+	memcpy_s((void *)library_base_address, CAVS18_MAX_MANIFEST_SIZE,
+			 (void *)buff_ptr, CAVS18_MAX_MANIFEST_SIZE);

total: 0 errors, 2 warnings, 30 checks, 636 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 2c7266623ff3 ("library manager: initial implementation") has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.